ReportersControllerTest.php 8.7 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225
  1. <?php
  2. declare(strict_types=1);
  3. namespace App\Tests\Integration\Admin;
  4. use App\Domain\Auth\Role;
  5. use App\Domain\Auth\TokenKind;
  6. use App\Tests\Integration\Support\AppTestCase;
  7. final class ReportersControllerTest extends AppTestCase
  8. {
  9. public function testNonAdminCannotCreateReporter(): void
  10. {
  11. $token = $this->createToken(TokenKind::Admin, role: Role::Operator);
  12. $response = $this->request(
  13. 'POST',
  14. '/api/v1/admin/reporters',
  15. ['Authorization' => 'Bearer ' . $token, 'Content-Type' => 'application/json'],
  16. json_encode(['name' => 'web-prod']) ?: null,
  17. );
  18. self::assertSame(403, $response->getStatusCode());
  19. }
  20. public function testAdminCanCreateAndFetchReporter(): void
  21. {
  22. $token = $this->createToken(TokenKind::Admin, role: Role::Admin);
  23. $created = $this->request(
  24. 'POST',
  25. '/api/v1/admin/reporters',
  26. ['Authorization' => 'Bearer ' . $token, 'Content-Type' => 'application/json'],
  27. json_encode([
  28. 'name' => 'web-prod-01',
  29. 'description' => 'first webserver',
  30. 'trust_weight' => 1.5,
  31. ]) ?: null,
  32. );
  33. self::assertSame(201, $created->getStatusCode());
  34. $body = $this->decode($created);
  35. self::assertSame('web-prod-01', $body['name']);
  36. self::assertSame(1.5, $body['trust_weight']);
  37. self::assertTrue($body['is_active']);
  38. $id = (int) $body['id'];
  39. $detail = $this->request('GET', "/api/v1/admin/reporters/{$id}", [
  40. 'Authorization' => 'Bearer ' . $token,
  41. ]);
  42. self::assertSame(200, $detail->getStatusCode());
  43. self::assertSame('web-prod-01', $this->decode($detail)['name']);
  44. }
  45. public function testCreateRejectsOutOfRangeTrustWeight(): void
  46. {
  47. $token = $this->createToken(TokenKind::Admin, role: Role::Admin);
  48. $response = $this->request(
  49. 'POST',
  50. '/api/v1/admin/reporters',
  51. ['Authorization' => 'Bearer ' . $token, 'Content-Type' => 'application/json'],
  52. json_encode(['name' => 'bad', 'trust_weight' => 5.0]) ?: null,
  53. );
  54. self::assertSame(400, $response->getStatusCode());
  55. $body = $this->decode($response);
  56. self::assertSame('validation_failed', $body['error']);
  57. self::assertArrayHasKey('trust_weight', $body['details']);
  58. }
  59. public function testDuplicateNameRejected(): void
  60. {
  61. $token = $this->createToken(TokenKind::Admin, role: Role::Admin);
  62. $this->request(
  63. 'POST',
  64. '/api/v1/admin/reporters',
  65. ['Authorization' => 'Bearer ' . $token, 'Content-Type' => 'application/json'],
  66. json_encode(['name' => 'dup']) ?: null,
  67. );
  68. $second = $this->request(
  69. 'POST',
  70. '/api/v1/admin/reporters',
  71. ['Authorization' => 'Bearer ' . $token, 'Content-Type' => 'application/json'],
  72. json_encode(['name' => 'dup']) ?: null,
  73. );
  74. self::assertSame(400, $second->getStatusCode());
  75. }
  76. public function testPatchUpdatesFields(): void
  77. {
  78. $token = $this->createToken(TokenKind::Admin, role: Role::Admin);
  79. $reporterId = $this->createReporter('web-edit');
  80. $patch = $this->request(
  81. 'PATCH',
  82. "/api/v1/admin/reporters/{$reporterId}",
  83. ['Authorization' => 'Bearer ' . $token, 'Content-Type' => 'application/json'],
  84. json_encode(['trust_weight' => 0.25, 'is_active' => false]) ?: null,
  85. );
  86. self::assertSame(200, $patch->getStatusCode());
  87. $body = $this->decode($patch);
  88. self::assertSame(0.25, $body['trust_weight']);
  89. self::assertFalse($body['is_active']);
  90. }
  91. public function testPatchTogglesAuditEnabled(): void
  92. {
  93. $token = $this->createToken(TokenKind::Admin, role: Role::Admin);
  94. $reporterId = $this->createReporter('web-audit-toggle');
  95. // Default is true on create.
  96. $detail = $this->request('GET', "/api/v1/admin/reporters/{$reporterId}", [
  97. 'Authorization' => 'Bearer ' . $token,
  98. ]);
  99. self::assertTrue($this->decode($detail)['audit_enabled']);
  100. $patch = $this->request(
  101. 'PATCH',
  102. "/api/v1/admin/reporters/{$reporterId}",
  103. ['Authorization' => 'Bearer ' . $token, 'Content-Type' => 'application/json'],
  104. json_encode(['audit_enabled' => false]) ?: null,
  105. );
  106. self::assertSame(200, $patch->getStatusCode());
  107. self::assertFalse($this->decode($patch)['audit_enabled']);
  108. }
  109. public function testAuditEnabledToggleEmitsDedicatedAuditRow(): void
  110. {
  111. // SEC_REVIEW F41: an admin flipping `audit_enabled` for a reporter
  112. // must leave a flat alertable trail SOC tooling can match on with
  113. // `action = 'reporter.audit_toggled'` — without walking into the
  114. // details_json `changes` blob of the standard `reporter.updated` row.
  115. $token = $this->createToken(TokenKind::Admin, role: Role::Admin);
  116. $reporterId = $this->createReporter('web-audit-toggle-audit');
  117. $this->request(
  118. 'PATCH',
  119. "/api/v1/admin/reporters/{$reporterId}",
  120. ['Authorization' => 'Bearer ' . $token, 'Content-Type' => 'application/json'],
  121. json_encode(['audit_enabled' => false]) ?: null,
  122. );
  123. $rows = $this->db->fetchAllAssociative(
  124. "SELECT action, details_json FROM audit_log WHERE target_type = 'reporter' AND target_id = ? ORDER BY id",
  125. [(string) $reporterId],
  126. );
  127. $actions = array_column($rows, 'action');
  128. // Both signals fire: the existing standard row plus the dedicated toggle.
  129. self::assertContains('reporter.updated', $actions);
  130. self::assertContains('reporter.audit_toggled', $actions);
  131. $toggleRow = null;
  132. foreach ($rows as $row) {
  133. if ($row['action'] === 'reporter.audit_toggled') {
  134. $toggleRow = $row;
  135. break;
  136. }
  137. }
  138. self::assertNotNull($toggleRow);
  139. $meta = json_decode((string) $toggleRow['details_json'], true);
  140. self::assertSame(true, $meta['from'] ?? null);
  141. self::assertSame(false, $meta['to'] ?? null);
  142. }
  143. public function testAuditEnabledNoOpDoesNotEmitDedicatedRow(): void
  144. {
  145. // PATCHing `audit_enabled` to its current value (no-op) must NOT
  146. // fire the toggle signal — SOC alerts would otherwise see noise.
  147. $token = $this->createToken(TokenKind::Admin, role: Role::Admin);
  148. $reporterId = $this->createReporter('web-audit-noop');
  149. // Default is true; PATCH it to true (no-op).
  150. $this->request(
  151. 'PATCH',
  152. "/api/v1/admin/reporters/{$reporterId}",
  153. ['Authorization' => 'Bearer ' . $token, 'Content-Type' => 'application/json'],
  154. json_encode(['audit_enabled' => true]) ?: null,
  155. );
  156. $actions = $this->db->fetchFirstColumn(
  157. "SELECT action FROM audit_log WHERE target_type = 'reporter' AND target_id = ?",
  158. [(string) $reporterId],
  159. );
  160. self::assertNotContains('reporter.audit_toggled', $actions);
  161. }
  162. public function testDeleteWithoutReportsSoftDeletes(): void
  163. {
  164. $token = $this->createToken(TokenKind::Admin, role: Role::Admin);
  165. $reporterId = $this->createReporter('web-disposable');
  166. $delete = $this->request('DELETE', "/api/v1/admin/reporters/{$reporterId}", [
  167. 'Authorization' => 'Bearer ' . $token,
  168. ]);
  169. self::assertSame(204, $delete->getStatusCode());
  170. $detail = $this->request('GET', "/api/v1/admin/reporters/{$reporterId}", [
  171. 'Authorization' => 'Bearer ' . $token,
  172. ]);
  173. self::assertSame(200, $detail->getStatusCode());
  174. self::assertFalse($this->decode($detail)['is_active']);
  175. }
  176. public function testDeleteWithReportsReturns409(): void
  177. {
  178. $token = $this->createToken(TokenKind::Admin, role: Role::Admin);
  179. $reporterId = $this->createReporter('web-with-reports');
  180. $categoryId = (int) $this->db->fetchOne(
  181. 'SELECT id FROM categories WHERE slug = :slug',
  182. ['slug' => 'brute_force']
  183. );
  184. $this->db->insert('reports', [
  185. 'category_id' => $categoryId,
  186. 'reporter_id' => $reporterId,
  187. 'ip_bin' => str_repeat("\0", 12) . "\xff\xff\x01\x02",
  188. 'ip_text' => '0.0.0.1',
  189. 'weight_at_report' => '1.00',
  190. 'received_at' => '2026-01-01 00:00:00',
  191. ]);
  192. $delete = $this->request('DELETE', "/api/v1/admin/reporters/{$reporterId}", [
  193. 'Authorization' => 'Bearer ' . $token,
  194. ]);
  195. self::assertSame(409, $delete->getStatusCode());
  196. }
  197. }